-
-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: threaded subprocs #4634
base: main
Are you sure you want to change the base?
rm: threaded subprocs #4634
Conversation
Wait is this the new default? Please make it behind a config flag in case it ever breaks. The old threaded subprocess were really buggy. I'm fine if it's on by default I just want a fallback |
The idea was to remove unthreading/threading behaviour without any disruptions. It will not be merged until then. It needs to be feature compatible, and also this is just at the start. |
8df1c3c
to
45ce361
Compare
45ce361
to
762f9e9
Compare
a35d0a1
to
1dc790f
Compare
Warning! No news item is found for this PR. |
related discussion #4710 |
1dc790f
to
f8be983
Compare
Hey @jnoortheen! It looks like it's great work! Please open issue for talking instead of "Discussion". Do you plan to continue work or where you stopped? |
I am not working on it currently. I rarely face errors related to this as I dont use cmd capturing. I will probably work on it iin future. |
found an earlier attempt here main...nothread |
Originally posted by @anki-code in #4710 (comment)
|
subprocess handling without threads, the aim is to solve various thread related issues like suspending/resuming and not using threads for capturing outputs.
Todos:
Related
#2159
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1
or 👍 comment